make temp uploads volume changes factor in the temp subpath #14246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
brandonkelly
deleted the
bugfix/11405-temp-uploads-volume-logic-with-subpath
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes temp uploads volume changes from #14141 and 97a08f8 more forgiving by factoring in the temp uploads location subpath.
If the Temp Uploads Location is set to a volume and a subpath is also defined, the volume is allowed to be used in the Assets field. (If the subpath is not specified, the volume is not allowed.)
An additional check is added to validate the default and restricted source + subpath combinations to ensure they’re not the same as specified in the Temp Uploads Location setting.
Related issues
#11405