Change generateUrl signature #14353
Merged
Change generateUrl signature #14353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkelty
commented
Feb 11, 2024
# Conflicts: # CHANGELOG.md
olivierbon
added a commit
to craftcms/feed-me
that referenced
this pull request
Apr 16, 2024
`\craft\helpers\Assets::generateUrl` no longer takes an FS as first argument (see [here](craftcms/cms#14353)). Craft 5 only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
\craft\helpers\Assets::generateUrltook a first argument ofBaseFsInterface, however, if you passed an FS, you could end up with the wrong URL if your asset volume had a subpath.Furthermore, I don't see any need to pass a volume either, since we're required to pass the asset. So, I removed the param entirely. If you want me to scale that back, I can leave it and just change the typing to
\craft\models\Volume. I dug around a bit and I've get to see a plugin passing anything but the fs or volume derived from the asset, and I'm not sure why you'd want to.