Feature/cms 1266 error summary in slideouts #14436
Conversation
|
@gcamacho079 another one that impacts the front-end.
|
|
@i-just @brianjhanson I tested this on JAWS/Chrome and NVDA/Firefox, and based on how these read the content (i.e. JAWS doesn’t read automatically, while NVDA does) I think there could be the potential that the visually-hidden text is missed unless we move it to the end of the heading. For example: "Found 3 errors in this tab; 5 errors in 2 tabs" where the italicized text would be visually-hidden. I was also able to trigger the "Found 0 errors" message again by correcting an error in the current tab, while leaving one in another tab (screenshot attached). Also, it still shows an error icon for the current tab. 
Based on those two things, I’m still wondering if we should just make the full message visible for everyone, as it makes it crystal clear from that single error box that the other tabs are the issue. |
|
Thanks @gcamacho079! I changed the heading to: This morning, I was able to reliably replicate that “0 errors” message (It was happening when you fix an error and then save immediately before autosave kicks in). Long story short, I have made a change to ensure we have the draft before attempting to do a full save, and that fixes this issue (and some other quirks). If you have a sec, give it a quick test and LMK if you think any further changes are needed. |
# Conflicts: # src/web/assets/cp/dist/cp.js # src/web/assets/cp/dist/cp.js.map
|
Works and looks great!! |
Description
Adds the error summary to slideouts.
Unlike the full-page approach, where there’s one error summary area that shows above the tabs, in slideouts, we have an error summary per tab, and each of those only shows the errors in a given tab.
Related issues
cms-1266