Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

money value can start with a minus #15567

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Aug 20, 2024

Description

Money value can start with a minus, too. If the value starts with a minus sign followed by only digits, we don’t have to normalise it.

Also, when normalising the value, use the field’s currency as a fallback. Without it, normalising, e.g. a plain text value of “10.99” can fail.

Related issues

#15565

i-just and others added 3 commits August 20, 2024 17:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
[ci skip]
@brandonkelly brandonkelly merged commit d2f7190 into 5.x Aug 21, 2024
@brandonkelly brandonkelly deleted the bugfix/15565-money-value-can-start-with-a-minus branch August 21, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants