Ensure DefineAssetUrlEvent is passed transform when parsing refs #16464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
\craft\services\Elements::_getRefTokenReplacementcoerces and an asset to a URL string via\craft\elements\Asset::__toString, which relies on any transform existing at\craft\elements\Asset::$_transformto get the correct transformed URL.However, when the
DefineAssetUrlEventevent is triggered and passed a transform,\craft\elements\Asset::$_transformis ignored.Something using
DefineAssetUrlEventmay then return the wrong URL, as receives anulltransform when\craft\elements\Asset::$_transformis actually set.This can end up interfering with
HtmlField's Asset transform URL parsing, as it expects values to be identical for correct substitution when parsing refs, but they may not be.Related issues
craftcms/ckeditor#336