Update Task.php #1816
Closed
Update Task.php #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In place of having to create NestedSetsTrait you can simply specify NestedSetsBehavior as an @mixin
|
No way! That's awesome. Can you please make the same changes to src/records/StructureElement.php, and delete src/db/NestedSetsTrait.php as well? |
|
This issue is present with these files: Sorry, but I just wanted to leave a recommendation. |
|
OK thanks anyway. There were a few other traits that could also be discarded. Resolved via c2c83ba. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In place of having to create
NestedSetsTraityou can simply specifyNestedSetsBehavioras an@mixin