Update base.html #3061
Closed
Update base.html #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a bug where the `<html lang>` attribute was hard-set to `en-US` rather than the current application language. (Refer: craftcms#3053)
|
@watarutmnh this has already been changed as per your request, no? |
|
@lukeyouell You are right, but I wanted to change to Craft2 too. |
|
Fix is going to be a little more complicated in Craft 2 since |
|
@brandonkelly I see the point. it's much more complicate than I thought. For example, en_bw the locale ID, should not convert to en-BW. It should be "BW" to along with ISO 3166 format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where the
<html lang>attribute was hard-set toen-USrather than the current application language. (Refer: #3053)