Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow conditionally empty uri patterns #4255

Closed
wants to merge 1 commit into from
Closed

Allow conditionally empty uri patterns #4255

wants to merge 1 commit into from

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented May 13, 2019

Fixes #4254

This allows the URI format to render to empty, so that entries in the same section may optionally omit URLs.

Screen Shot 2019-05-13 at 10 40 00 AM

Screen Shot 2019-05-13 at 10 38 34 AM

@brandonkelly
Copy link
Member

Thanks for the PR! Took the commit in a slightly different direction though.

@timkelty timkelty deleted the allow-contionally-empty-uri-patterns branch May 13, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants