Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expiryDate from actionCreateToken #4683

Closed
wants to merge 1 commit into from
Closed

Remove expiryDate from actionCreateToken #4683

wants to merge 1 commit into from

Conversation

jordikroon
Copy link

Shared URL's will automatically expire after 24 hours (P1D).

This PR removed the expiryDate from the createToken method call. Doing so will change the expiration of the preview token to make it match with the defaultTokenDuration config setting.

This defaultTokenDuration config value has a default value of 86400 / 1 day, thus only those who have altered this value will have a different behaviour.

@codecov
Copy link

codecov bot commented Jul 31, 2019

Codecov Report

Merging #4683 into develop will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4683      +/-   ##
=============================================
+ Coverage      31.64%   31.65%   +<.01%     
  Complexity     12879    12879              
=============================================
  Files            531      531              
  Lines          38582    38581       -1     
=============================================
  Hits           12211    12211              
+ Misses         26371    26370       -1
Impacted Files Coverage Δ Complexity Δ
src/controllers/LivePreviewController.php 0% <0%> (ø) 8 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1674573...6ff6cec. Read the comment docs.

@brandonkelly
Copy link
Member

The file you edited is the old Live Preview controller, which is only in used by categories and some third party element types, specifically for Live Preview, where I think a 24 hour limit was intentional and reasonable.

I’ve just made the same change to the new Preview controller though, which is used for previewing entries (both Live Preview and the Share button), so it makes more sense to have that one be configurable.

@jordikroon
Copy link
Author

I missed that. They looked similar. Thanks for adding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants