Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: fix deprecation warning and error in PhpStorm #4772

Merged
merged 12 commits into from
Aug 28, 2019

Conversation

putyourlightson
Copy link

@putyourlightson putyourlightson commented Aug 19, 2019

Fixes the deprecation warning (see http://phptest.club/t/bootstrap-deprecations-in-3-0/2196):

DEPRECATION: 'settings: bootstrap: _bootstrap.php' option is deprecated! Replace it with: 'bootstrap: _bootstrap.php' (not under settings section). See https://bit.ly/2YrRzVc 

And adds ob_start(); to the main _bootstrap.php file to prevent headers already sent errors being thrown when running tests through PhpStorm (https://stackoverflow.com/questions/31175636/headers-already-sent-running-unit-tests-in-phpstorm/55040543#55040543).

@putyourlightson putyourlightson changed the title Fix deprecation warning and error in PhpStorm Testing: fix deprecation warning and error in PhpStorm Aug 19, 2019
putyourlightson pushed a commit to putyourlightson/craft-campaign that referenced this pull request Aug 19, 2019
codeception.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #4772 into develop will decrease coverage by 2.05%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #4772      +/-   ##
============================================
- Coverage      33.56%   31.5%   -2.06%     
+ Complexity     13548   12922     -626     
============================================
  Files            601     530      -71     
  Lines          40808   38680    -2128     
============================================
- Hits           13696   12186    -1510     
+ Misses         27112   26494     -618
Impacted Files Coverage Δ Complexity Δ
src/test/TestSetup.php 0% <0%> (ø) 44 <0> (-4) ⬇️
src/volumes/Temp.php 0% <0%> (-54.55%) 5% <0%> (ø)
src/elements/db/MatrixBlockQuery.php 0% <0%> (-44.88%) 28% <0%> (ø)
src/helpers/StringHelper.php 82.43% <0%> (-17.27%) 99% <0%> (-60%)
src/elements/db/GlobalSetQuery.php 50% <0%> (-10.87%) 6% <0%> (-2%)
src/helpers/Template.php 16.66% <0%> (-8.53%) 46% <0%> (-12%)
src/services/Path.php 47.18% <0%> (-7.05%) 58% <0%> (ø)
src/elements/MatrixBlock.php 0% <0%> (-6.46%) 47% <0%> (ø)
src/helpers/Image.php 82.14% <0%> (-5.54%) 53% <0%> (+1%)
src/db/Query.php 64.93% <0%> (-5.2%) 33% <0%> (ø)
... and 133 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72a3873...1755a98. Read the comment docs.

@gtettelaar
Copy link
Contributor

@angrybrad Should be ready for you to have a look at

@gtettelaar gtettelaar requested a review from angrybrad August 23, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants