-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing: fix deprecation warning and error in PhpStorm #4772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
putyourlightson
changed the title
Fix deprecation warning and error in PhpStorm
Testing: fix deprecation warning and error in PhpStorm
Aug 19, 2019
putyourlightson
pushed a commit
to putyourlightson/craft-campaign
that referenced
this pull request
Aug 19, 2019
gtettelaar
suggested changes
Aug 19, 2019
gtettelaar
reviewed
Aug 19, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4772 +/- ##
============================================
- Coverage 33.56% 31.5% -2.06%
+ Complexity 13548 12922 -626
============================================
Files 601 530 -71
Lines 40808 38680 -2128
============================================
- Hits 13696 12186 -1510
+ Misses 27112 26494 -618
Continue to review full report at Codecov.
|
<http://phptest.club/t/bootstrap-deprecations-in-3-0/2196> No need for these setup classes.
@angrybrad Should be ready for you to have a look at |
gtettelaar
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the deprecation warning (see http://phptest.club/t/bootstrap-deprecations-in-3-0/2196):
And adds
ob_start();
to the main_bootstrap.php
file to preventheaders already sent
errors being thrown when running tests through PhpStorm (https://stackoverflow.com/questions/31175636/headers-already-sent-running-unit-tests-in-phpstorm/55040543#55040543).