Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Stripe gateway #28

Closed
andris-sevcenko opened this issue Sep 26, 2018 · 2 comments
Closed

Refactor Stripe gateway #28

andris-sevcenko opened this issue Sep 26, 2018 · 2 comments
Assignees
@andris-sevcenko

Comments

@andris-sevcenko
Copy link
Contributor

Current Strip gateway should be refactored, splitting out the common functionality to a base gateway, to reduce code duplication when implementing #26 and #27

Related: #25
@andris-sevcenko andris-sevcenko self-assigned this Sep 26, 2018
@stenvdb
Copy link

stenvdb commented Apr 15, 2019

Hi @andris-sevcenko what is the progress on this issue? I'm wondering if we can expect different gateway types soon for Stripe. I'm myself interested in seeing Bankcontact supported.

andris-sevcenko added a commit that referenced this issue Apr 29, 2019
@andris-sevcenko
Close #28
ae3d9d0
@andris-sevcenko
Copy link
Contributor Author

We're working on EU SCA support for Stripe. For the change to be backward compatible, this requires a new gateway, so this is happening now.

As far as Bankcontact support goes - can you add a new issue for this?

@stenvdb stenvdb mentioned this issue Apr 29, 2019
Closed
@johnwbaxter johnwbaxter mentioned this issue Sep 24, 2019
Closed
@cloudgrayau cloudgrayau mentioned this issue Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andris-sevcenko andris-sevcenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stenvdb @andris-sevcenko