Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with Commerce 5 #1448

Merged
merged 5 commits into from
May 27, 2024
Merged

Compatible with Commerce 5 #1448

merged 5 commits into from
May 27, 2024

Conversation

lukeholder
Copy link
Member

Description

  • Fixes price import mapping (should be importing to basePrice now)
  • Adds support for updating inventory in the primary inventory location for the variant
  • Moves the promotable, freeShipping, taxCategoryId, shippingCategoryId, availableForPurchaseto the variant (purchasable), and renamedhasUnlimitedStocktoinventoryTracked`

Related issues

#1439
#1428

@lukeholder lukeholder requested a review from angrybrad as a code owner May 22, 2024 03:09
@lukeholder
Copy link
Member Author

To get the compatibility release early and test this PR, change your craftcms/feed-me requirement in composer.json to:

"require": {
  "craftcms/feed-me": "dev-feature/commerce-5-support as 6.0.1"
  "...": "..."
}

Then run composer update.

@angrybrad
Copy link
Member

angrybrad commented May 23, 2024

@lukeholder this all works on Craft 4 as well? i.e. since Feed Me 6 is Craft 5 specific, but Craft 5 also works with Commerce 4, should these changes apply to Craft 4 / Feed Me 5 as well?

//cc @i-just

@angrybrad angrybrad merged commit 7ed4339 into 6.x May 27, 2024
@angrybrad angrybrad deleted the feature/commerce-5-support branch May 27, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants