-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document InfluxDB I/O procedures #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this article. Apologies that I have quite a few suggestions to reshape it.
-
Please design the tutorial to be self-contained for users approaching it without much ado, similar to what I had suggested on the MQTT tutorial.
An option could be to use Docker across the board, even for invoking
ctk load table
, so readers/users will effectively not have to install anything but a container subsystem, because all software will be invoked there, both services and client tools. -
In the context of the CrateDB Guide, please omit the focus on influxio, but just reference it at the end of the article. If you want to write an article about influxio, it should be a dedicated and separate one, but also not copy its README.
-
As I suggested to remove many fragments from this documentation page, it would be sad if they would be lost. So, I provided guidance over there where those updates should have been submitted to.
-
The CI job currently fails, because
influxdb.md
needs to be added to another page's toctree.checking consistency... /path/to/docs/integrate/etl/influxdb.md: WARNING: document isn't included in any toctree
docs/integrate/etl/influxdb.md
Outdated
(setup-influxio)= | ||
## Setup | ||
|
||
`influxio` can be installed with pip: | ||
|
||
:::{code} console | ||
pip install influxio | ||
::: | ||
|
||
You will also need the [cratedb-toolkit](https://github.com/crate-workbench/cratedb-toolkit/tree/main/cratedb_toolkit/io#installation) | ||
to load the data into your CrateDB instance. It can be installed with: | ||
|
||
:::{code} console | ||
pip install --upgrade 'cratedb-toolkit[all]' | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When aiming to use CrateDB Toolkit, installing influxio
separately is not needed. The right installation command would be pip install 'cratedb-toolkit[influxdb]'
.
In general, in the main section of the article, I would omit all details about influxio, and only present the corresponding CLI command of CrateDB Toolkit.
At the end of the article, I would link to the documentation of influxio, conveying the message that it offers a few more commands which help in different scenarios like the one you've picked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, there is no pip install
command inside. When aiming for conveying that tutorial "the Docker way", like proposed at #75 (comment), we will probably not need any of those. JFYI.
docs/integrate/etl/influxdb.md
Outdated
:::{code} console | ||
influx setup \ | ||
--username user1 \ | ||
--password 49jk8FQB$]1 \ | ||
--token token123 \ | ||
--org example \ | ||
--bucket testdrive \ | ||
--force | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That command would fail when no InfluxDB service is running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can find corresponding commands to start the services using Docker on https://influxio.readthedocs.io/development.html.
Co-authored-by: Andreas Motl <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Added the Docker variant, but this is only
So I should still instruct to install those, yes? |
docs/integrate/etl/influxdb.md
Outdated
:::{code} console | ||
export CRATEDB_SQLALCHEMY_URL=crate://crate@localhost:4200/testdrive/demo | ||
ctk load table influxdb2://example:token123@localhost:8086/testdrive/demo | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus / Subsequent iteration: CrateDB Toolkit is also available per OCI image.
See also #75 (comment).
:::{code} console | ||
crash --command "SELECT * FROM testdrive.demo;" | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the OCI image of Toolkit also includes crash
out of the box.
See also #75 (comment).
ctk pulls in influxio when installed correspondingly.
It should be included into the Docker image on behalf of the
|
Co-authored-by: Andreas Motl <[email protected]>
Please also use such aliases to provide optimal UX to readers of the documentation when it comes to invoking tools, and why not just everything. ;] Those are aliases for all required programs in a nutshell, also alphanumerically sorted:
Optionally, some (or just all?) commands would probably also need to use Feel free to do anything of that on a later iteration, based on your energy and spirits. The current version is more than good enough to have it, and can also be improved later. Don't forget to squash your commits, into a single one with a meaningful message before merging. Thanks! |
That's good, thank you very much. Running it all on docker would be ideal for sure. |
Co-authored-by: Andreas Motl <[email protected]>
Hi again. I think it should be good now. I did it a bit differently than in the docs, although it's still all docker. Looked easier to me this way. What do you think? |
One thing to mention - On macOS (Apple Silicon) I got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful. Thanks!
Hi. I did not review the HTML preview, apologies. Apparently, there is something wrong on the folding/nesting of elements, see https://cratedb.com/docs/guide/integrate/etl/influxdb.html. Can I ask you to investigate and fix it? |
I missed that too, thanks for checking. #78 will help |
Sorry for eventually merging this too early. It looks like the commits have not been squashed. |
About
Main documentation for CrateDB Toolkit's InfluxDB I/O subsystem, based on influxio.
Preview
References