Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: Standard way for crc to communicate about a local registry #1254

Open
nicks opened this issue May 26, 2020 · 5 comments
Open
Labels
kind/enhancement New feature or request status/pinned Prevents the stale bot from closing the issue

Comments

@nicks
Copy link

nicks commented May 26, 2020

Many local dev clusters support a local registry, to make pushing images directly to the cluster fast. But every cluster documents it with manual shell scripts. Here's the one for CRC:

https://github.com/code-ready/crc/wiki/Adding-an-insecure-registry

Because every cluster is slightly different, this makes it hard for tools to automate this work for users. I'm working on a KEP for a shared standard so that local dev clusters have a way to notify devtools (IDEs, local containerized dev environments) that they support this feature.

kubernetes/enhancements#1757

I'm posting this here to make sure that CRC maintainers are aware of the proposal and have the opportunity to comment. Implementing it might be as simple as adding a step to the Wiki document above.

Happy to answer any questions or concerns. Thanks!

@anjannath anjannath added the kind/enhancement New feature or request label Jun 2, 2020
@stale
Copy link

stale bot commented Aug 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Aug 1, 2020
@anjannath anjannath added status/pinned Prevents the stale bot from closing the issue and removed status/stale Issue went stale; did not receive attention or no reply from the OP labels Aug 4, 2020
@praveenkumar
Copy link
Member

@nicks apologize for a late reply but I went through the enhancement request and it does make sense, since this enhancement request is already merged, any idea when it is implemented as part of sig ( which version of k8s? )

@nicks
Copy link
Author

nicks commented Aug 28, 2020

@praveenkumar there's actually no code needed in Kubernetes itself! kubernetes/enhancements#1755. You can do this with any version of Kubernetes that supports ConfigMaps.

We simply need the different cluster distros that offer a registry to set up a configmap to advertise it on startup. I've been slow about coordinating efforts, but we're getting there!

@nicks
Copy link
Author

nicks commented Aug 28, 2020

(you're welcome to take a crack at it on your own...i can try to send you a pr but it just takes me a while to find the time...)

@praveenkumar
Copy link
Member

@nicks this enhancement right now only talks about insecure local registry but in openshift side you can have any type of registry along with CA so do you think it is good to deal it like openshift way or have two different approach where one approach is just use what this enhancement says but when there is non-insecure registry then go with openshift way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request status/pinned Prevents the stale bot from closing the issue
Projects
None yet
Development

No branches or pull requests

3 participants