Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/base ref set #517

Closed
wants to merge 6 commits into from
Closed

Feature/base ref set #517

wants to merge 6 commits into from

Conversation

CFoye-Creare
Copy link
Contributor

Properly create base_ref property and add a setter.

@CFoye-Creare CFoye-Creare requested a review from mpu-creare June 3, 2024 16:00
@CFoye-Creare CFoye-Creare self-assigned this Jun 3, 2024
@CFoye-Creare CFoye-Creare changed the base branch from develop to main-3.X June 3, 2024 16:01
@mpu-creare
Copy link
Contributor

Looks like some child nodes overwrite base_ref, so this solution doesn't work.

mpu-creare
mpu-creare approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@mpu-creare mpu-creare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good.

@mpu-creare
Copy link
Contributor

We'll merge this into main along with a few other changes to make a new release.

@rparker-creare
Copy link
Collaborator

We manually merged this into develop-3.X

@rparker-creare rparker-creare mentioned this pull request Jun 28, 2024
Merged
@rparker-creare rparker-creare deleted the feature/base_ref_set branch June 28, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpu-creare mpu-creare mpu-creare approved these changes

Assignees

@CFoye-Creare CFoye-Creare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CFoye-Creare @mpu-creare @rparker-creare