fix: add validation in the user role guard (#854)

* fix: add validation in the user role guard Signed-off-by: KulkarniShashank <[email protected]> * fix: modify validation in the user role guard Signed-off-by: KulkarniShashank <[email protected]> * fix: modify validation and error message changes in the user role guard Signed-off-by: KulkarniShashank <[email protected]> --------- Signed-off-by: KulkarniShashank <[email protected]>
credebl · Sep 11, 2024 · 5201bb7 · 5201bb7
1 parent 64f0787
commit 5201bb7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/apps/api-gateway/src/authz/guards/user-role.guard.ts b/apps/api-gateway/src/authz/guards/user-role.guard.ts
@@ -8,8 +8,12 @@ export class UserRoleGuard implements CanActivate {
 
     const { user } = request;
 
-    if (user?.userRole && user?.userRole.includes('holder')) {
-      throw new ForbiddenException('This role is a holder.');
+    if (!user?.userRole) {
+      throw new ForbiddenException('This role is not a holder.');
+    }
+
+    if (!user?.userRole.includes('holder')) {
+      throw new ForbiddenException('This role is not a holder.');
     }
 
     return true;