Merge pull request #710 from credebl/fix/get-verification-by-schemaId

fix: Unable to get credDef for schemaId with surrounding spaces
credebl · May 16, 2024 · e3dfbd3 · e3dfbd3
2 parents 02a1ce8 + e9b3606
commit e3dfbd3
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/apps/api-gateway/src/credential-definition/credential-definition.controller.ts b/apps/api-gateway/src/credential-definition/credential-definition.controller.ts
@@ -16,6 +16,7 @@ import { CreateCredentialDefinitionDto } from './dto/create-cred-defs.dto';
 import { OrgRoles } from 'libs/org-roles/enums';
 import { Roles } from '../authz/decorators/roles.decorator';
 import { CustomExceptionFilter } from 'apps/api-gateway/common/exception-handler';
+import { TrimStringParamPipe } from '@credebl/common/cast.helper';
 
 
 @ApiBearerAuth()
@@ -59,7 +60,7 @@ export class CredentialDefinitionController {
   @ApiResponse({ status: HttpStatus.OK, description: 'Success', type: ApiResponseDto })
   @UseGuards(AuthGuard('jwt'))
   async getCredentialDefinitionBySchemaId(
-    @Param('schemaId') schemaId: string,
+    @Param('schemaId', TrimStringParamPipe) schemaId: string,
     @Res() res: Response
   ): Promise<Response> {
 

diff --git a/libs/common/src/cast.helper.ts b/libs/common/src/cast.helper.ts
@@ -1,4 +1,5 @@
-import { BadRequestException } from '@nestjs/common';
+import { BadRequestException, PipeTransform } from '@nestjs/common';
+import { plainToClass } from 'class-transformer';
 import {
   ValidationArguments,
   ValidationOptions,
@@ -140,6 +141,26 @@ export class ImageBase64Validator implements ValidatorConstraintInterface {
   }
 }
 
+export class TrimStringParamPipe implements PipeTransform {
+  // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/explicit-function-return-type
+  transform(value: string) {
+    return plainToClass(String, value.trim());
+  }
+}
+
+// export const IsNotUUID = (validationOptions?: ValidationOptions): PropertyDecorator => (object: object, propertyName: string) => {
+//   registerDecorator({
+//     name: 'isNotUUID',
+//     target: object.constructor,
+//     propertyName,
+//     options: validationOptions,
+//     validator: {
+//       validate(value) {
+//         return !isUUID(value);
+//       }
+//     }
+//   });
+// };
 export class AgentSpinupValidator {
   private static validateField(value: string, errorMessage: string): void {
     if (!value) {