refactor: on premises agent configure #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 16, 2024 17:10
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
…7-on-prem-agent
Signed-off-by: KulkarniShashank <[email protected]>
tipusinghaw
reviewed
May 22, 2024
| @@ -37,7 +37,6 @@ export interface IAgentConfigure { | |||
| apiKey: string; | |||
| orgId: string; | |||
| network?: string; | |||
| tenant?: boolean; | |||
There was a problem hiding this comment.
Please make sure this will not break tenancy flow
There was a problem hiding this comment.
Yes I tested and tenantId by default taking null value
apps/agent-service/src/repositories/agent-service.repository.ts
Outdated
Show resolved
Hide resolved
apps/agent-service/src/repositories/agent-service.repository.ts
Outdated
Show resolved
Hide resolved
added 7 commits
May 22, 2024 17:48
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
…7-on-prem-agent
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
|
tipusinghaw
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Refactored the configuration process for the on-premises agent.
Why
Improved and added the .educreds folder for the store configuration
How