Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit 10 organizations per user #743

Merged
merged 9 commits into from
Jun 3, 2024

Conversation

pranalidhanavade
Copy link
Contributor

What

  • Changes in POST /orgs Create a new Organization API. Implemented logic to restricted user to create more than 10 organizations.
  • Changes in POST /users/org-invitations/{invitationId} accept/reject organization invitation API. Implemented logic to restrict user for accepting organization invitation if user is already associated with 10 organziations

Signed-off-by: pranalidhanavade <[email protected]>
@pranalidhanavade pranalidhanavade self-assigned this May 31, 2024
@pranalidhanavade pranalidhanavade linked an issue May 31, 2024 that may be closed by this pull request
Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: pranalidhanavade <[email protected]>
Copy link
Contributor

@bhavanakarwade bhavanakarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Contributor

@tipusinghaw tipusinghaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@@ -632,6 +632,16 @@ export class OrganizationRepository {
}
}

async countUserOrganizations(userId: string): Promise<number> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
async countUserOrganizations(userId: string): Promise<number> {
async userOrganizationCount(userId: string): Promise<number> {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Signed-off-by: pranalidhanavade <[email protected]>
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pranalidhanavade pranalidhanavade merged commit cab7a54 into develop Jun 3, 2024
2 checks passed
@pranalidhanavade pranalidhanavade deleted the 702-feat-limit-10-organizations-per-user branch June 4, 2024 07:56
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

* feat: limit 10 orgs per user

Signed-off-by: pranalidhanavade <[email protected]>

---------

Signed-off-by: pranalidhanavade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Limit 10 organizations per user
4 participants