Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: delete ecosystem by org Id #768

Merged
merged 17 commits into from
Jun 19, 2024
Merged

feat: delete ecosystem by org Id #768

merged 17 commits into from
Jun 19, 2024

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Jun 13, 2024 •
edited
Loading

What?

  • Implemented API to delete ecosystem by orgId
  • Implemented send email functionality to inform ecosystem lead
  • Error handling

Why?

  • This functionality is for maintaining organizational integrity by allowing the organization owner, if they are an ecosystem member, to remove their participation from the ecosystem.
  • Sending emails ensures transparency and communication, informing ecosystem lead about their members are remove their participation from ecosystem.

@bhavanakarwade
feat: delete ecosystem members
d15d0e7 
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade bhavanakarwade self-assigned this Jun 13, 2024
@bhavanakarwade bhavanakarwade added the enhancement New feature or request label Jun 13, 2024
@bhavanakarwade bhavanakarwade linked an issue Jun 13, 2024 that may be closed by this pull request
feat: Delete references of organization #749
Closed
7 tasks
@bhavanakarwade bhavanakarwade changed the title feat: delete ecosystem members feat: delete ecosystem by org Id Jun 18, 2024
tipusinghaw
tipusinghaw reviewed Jun 18, 2024
View reviewed changes
apps/ecosystem/src/ecosystem.module.ts Show resolved Hide resolved
apps/ecosystem/src/ecosystem.repository.ts Show resolved Hide resolved
apps/ecosystem/src/ecosystem.repository.ts Show resolved Hide resolved
apps/ecosystem/src/ecosystem.repository.ts Outdated Show resolved Hide resolved
apps/ecosystem/src/ecosystem.repository.ts Show resolved Hide resolved
apps/issuance/src/issuance.repository.ts Outdated Show resolved Hide resolved
apps/user/src/user.service.ts Outdated Show resolved Hide resolved
@bhavanakarwade bhavanakarwade requested a review from GHkrishna June 19, 2024 11:44
GHkrishna
GHkrishna approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

apps/api-gateway/src/ecosystem/ecosystem.controller.ts Show resolved Hide resolved
apps/api-gateway/src/ecosystem/ecosystem.controller.ts Show resolved Hide resolved
libs/common/src/cast.helper.ts Outdated Show resolved Hide resolved
libs/common/src/response-messages/index.ts Outdated Show resolved Hide resolved
libs/common/src/response-messages/index.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code

See analysis details on SonarCloud

KulkarniShashank
KulkarniShashank approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@KulkarniShashank KulkarniShashank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@bhavanakarwade bhavanakarwade merged commit c11ab15 into develop Jun 19, 2024
2 checks passed
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
10fc963 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
bd57fb2 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
99dc0c6 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
8c410dc 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
bd7c8c6 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
ebb4cb9 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@bhavanakarwade
feat: delete ecosystem by org Id (#768)
6147aff 
* feat: delete ecosystem members

Signed-off-by: bhavanakarwade <[email protected]>

* wip: delete ecosystem

Signed-off-by: bhavanakarwade <[email protected]>

* fix: eslint issues

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved trimmedstring issue

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: interface type

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get organization details function

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved conflicts

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: made description field required

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: function name

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw left review comments

@KulkarniShashank KulkarniShashank KulkarniShashank approved these changes

@GHkrishna GHkrishna GHkrishna approved these changes

Assignees

@bhavanakarwade bhavanakarwade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Delete references of organization
4 participants
@bhavanakarwade @KulkarniShashank @GHkrishna @tipusinghaw