Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect response while creating an offer using multiple connection Ids #769

Merged
merged 25 commits into from
Jun 13, 2024

Conversation

bhavanakarwade
Copy link
Contributor

@bhavanakarwade bhavanakarwade commented Jun 13, 2024

What?

Why?

  • To provide clear feedback on the status of each issuance attempt, improving error handling and user experience

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: bhavanakarwade <[email protected]>
@bhavanakarwade bhavanakarwade self-assigned this Jun 13, 2024
@bhavanakarwade bhavanakarwade added the bug Something isn't working label Jun 13, 2024
@bhavanakarwade bhavanakarwade requested a review from GHkrishna June 13, 2024 07:34
Copy link
Contributor

@GHkrishna GHkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Signed-off-by: bhavanakarwade <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bhavanakarwade bhavanakarwade merged commit eb14d22 into develop Jun 13, 2024
2 checks passed
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
…tion Ids (#769)

* fix: transaction request message

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: response message

Signed-off-by: bhavanakarwade <[email protected]>

* fix: resolved add organization of other user issue

Signed-off-by: bhavanakarwade <[email protected]>

* fix: apply trim validation for nested array elements

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: validations

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload changes

Signed-off-by: bhavanakarwade <[email protected]>

* fix: payload property

Signed-off-by: bhavanakarwade <[email protected]>

* reafctor: master table data

Signed-off-by: bhavanakarwade <[email protected]>

* refactor: get ab organization query

Signed-off-by: bhavanakarwade <[email protected]>

* fix: update master table entries

Signed-off-by: bhavanakarwade <[email protected]>

* fix: refactored response for create credential offer

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants