Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: attributes payload changes while creating a proofrequest #907

Merged
merged 5 commits into from
Aug 14, 2024
Merged

refactor: attributes payload changes while creating a proofrequest #907

merged 5 commits into from
Aug 14, 2024

Conversation

bhavanakarwade
Copy link
Contributor

What?

  • Refactor create OOB proof request function

Why?

  • To ensure that attributes are correctly included when creating a proof request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bhavanakarwade bhavanakarwade merged commit 8fee70b into develop Aug 14, 2024
2 checks passed
KulkarniShashank pushed a commit that referenced this pull request Sep 6, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
4535d95 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
1b6d368 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
d9801e1 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
efdec41 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 11, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
e5198a9 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
157a83c 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
KulkarniShashank pushed a commit that referenced this pull request Sep 12, 2024
@bhavanakarwade
refactor: attributes payload changes while creating a proofrequest (#907
ae00fea 
)

* fix: verification bugs

Signed-off-by: bhavanakarwade <[email protected]>

* fix: take regex in common constants

Signed-off-by: bhavanakarwade <[email protected]>

* fix: added prooftype for polygon and no ledger

Signed-off-by: bhavanakarwade <[email protected]>

* fix: add proof type in common constants

Signed-off-by: bhavanakarwade <[email protected]>

---------

Signed-off-by: bhavanakarwade <[email protected]>
Signed-off-by: KulkarniShashank <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tipusinghaw tipusinghaw tipusinghaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhavanakarwade @tipusinghaw