42 #1
Open
42 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add postcss to handle browser prefixing and conversion of pixels to rems with a base font size of 16 pixels. So a pixel measurement of 20px would be converted to 1.25rem in the output answers.css. Additionally, convert line- height measurements to unitless measurements. This allows ensures Answers Lib's compliance with WCAG 2.1 Success Criteria 1.4.4.
Updates DOM.queryAll to return an array so that clients can use forEach (all calling code currently does). Also, replaces DOMParser().parseFromString with document.createRange() for better browser support & performance. Keeps DOMParser as a fallback for jest as their is a bug in jsdom, see: jsdom/jsdom#399 for details.
Instead of automatically fetching the businessId from the server, have it as an option in the config. Currently optional, and analytics will be disabled without it.
Incorporate SearchBar & Nav templates and functionality based on updated designs.
When there are too many links to fit in the NavigationComponent's container, move items that are too long into a "more" dropdown.
Adds new AccordionResult template and updates UniversalResults to respond to a new "useAccrdion" VerticalResult config property, which will cause the Vertical to use the AccordionResult component instead of the standard Results component.
Modify UnversalResultsComponent to pass section specific configuration down to the Section model so it can be rendered by the resultssectionheader.hbs template. Additionally, modify the Section model to provide a default sectionTitle param to resultssectionheader.hbs by deriving it from the verticalConfigId by default. # Conflicts: # src/ui/components/results/universalresultscomponent.js
Updates DirectAnswers, Results and ResultsItem templates based on updated designs. Also adds a new resultssectionheader template to encapsulate new heading designs. Additionally adds some default data mapping to the core/models/result.js Result class. # Conflicts: # src/ui/sass/answers.scss
…e template config.templateName was defined but not used by any of the Components. This changes each component to respect config.templateName if it's defined and if not, fallback to the default templateName for the Component. For Components with multiple allowable templates, this will allow implementors to choose a variation without overriding the template parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.