Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for s390x #79

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add support for s390x #79

merged 1 commit into from
Apr 8, 2024

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 28, 2024 •
edited
Loading

What type of PR is this?

/kind ci

What this PR does / why we need it:

Adding support to build s390x packages.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Requires:

Does this PR introduce a user-facing change?

Added support for `s390x` packages and bundles.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note kind/ci dco-signoff: yes Indicates the PR's author has DCO signed all their commits. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2024
@saschagrunert saschagrunert force-pushed the s390x branch 2 times, most recently from b99af87 to 2e2b09b Compare February 28, 2024 11:36
@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@saschagrunert saschagrunert mentioned this pull request Feb 29, 2024
Closed
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2024
@saschagrunert saschagrunert mentioned this pull request Mar 20, 2024
Closed
@MaryJulian17
Copy link

MaryJulian17 commented Apr 4, 2024 •
edited
Loading

Is the 'obs / bundle / build / main / s390x (pull_request)' check the one that's holding up the merge for s390x support? Is there any other hold up , do we have a target date on when s390x packages are available?

@saschagrunert
Copy link
Member Author

Is the 'obs / bundle / build / main / s390x (pull_request)' check the one that's holding up the merge for s390x support? Is there any other hold up , do we have a target date on when s390x packages are available?

I'm planning to cut a conmon-rs release next week which is the only blocker right now.

@saschagrunert saschagrunert force-pushed the s390x branch 2 times, most recently from 6aa5910 to 8ebea78 Compare April 8, 2024 07:42
@saschagrunert
Add support for s390x
651cf1f 
Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert marked this pull request as ready for review April 8, 2024 07:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2024
@openshift-ci openshift-ci bot requested review from hasan4791 and QiWang19 April 8, 2024 07:46
@saschagrunert
Copy link
Member Author

@cri-o/cri-o-maintainers PTAL

@saschagrunert
Copy link
Member Author

@kwilczynski do you mind a lgtm here?

@kwilczynski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwilczynski, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 91270d1 into cri-o:main Apr 8, 2024
29 checks passed
@saschagrunert saschagrunert deleted the s390x branch April 8, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasan4791 hasan4791 Awaiting requested review from hasan4791

@QiWang19 QiWang19 Awaiting requested review from QiWang19

Assignees

@kwilczynski kwilczynski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. kind/ci lgtm Indicates that a PR is ready to be merged. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @kwilczynski @MaryJulian17