Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from Grafana's plugin review #25

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Address feedback from Grafana's plugin review #25

merged 4 commits into from
Nov 5, 2024

Conversation

dcheckoway
Copy link
Collaborator

  • Properly close all HTTP response bodies.
  • Remove unnecessary "did settings change" logic in CheckHealth.
  • Enable the release workflow (I added the secret in GitHub).
  • Updates (CHANGELOG, package.json) in prep for the v1.1.1 release.

@dcheckoway dcheckoway merged commit 51153ca into main Nov 5, 2024
10 checks passed
@dcheckoway dcheckoway deleted the grafana-review-feedback branch November 5, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsalvinho itsalvinho itsalvinho approved these changes

@cdahl-dev cdahl-dev Awaiting requested review from cdahl-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcheckoway @itsalvinho