Add enable option to the service configuration. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-klebanov
reviewed
Jul 19, 2024
| @@ -65,6 +65,7 @@ nodeSelector: {} | |||
| # topologySpreadConstraints: [] | |||
|
|
|||
| service: | |||
| enable: true | |||
There was a problem hiding this comment.
Can we add the description of this value to helm-chart-sources/logstream-workergroup/README.md
There was a problem hiding this comment.
Added config values to the readme in the logstream-workergroup as requested
a-klebanov
requested changes
Jul 26, 2024
|
I’ll add this today
…On Fri, Jul 26, 2024 at 10:19 Andrey Klebanov ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Add documentation for the new option
—
Reply to this email directly, view it on GitHub
<#190 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AYYWRR7ND7KARN3RWOSJSCTZOJSJ3AVCNFSM6AAAAABC6LDXQ2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMBSGEZDINRUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
garrettprimm
requested review from
sdball,
michalbiesek and
benji-york
as code owners
|
@a-klebanov Documentation added to the README.md in the logstream-workgroup chart. anything else? |
a-klebanov
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment, we break workergroups up by pull source or by a push source. My pull sources that pull data from kinesis, s3, or other api endpoints don't need any service configured. I'd like to have this option as it reduces the work around in automation to provide a default list of ports to create a service even when one isn't needed.