Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explore fixes of coverage actions #762

Merged
merged 2 commits into from
Nov 23, 2024
Merged

explore fixes of coverage actions #762

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
310f4b9
attempt swap order of coverage actions
fmigneault Nov 22, 2024
f248857
disable codecov test analytics to bring back useful coverage reports …
fmigneault Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,13 +131,15 @@ jobs:
- name: Run Tests
run: make stop ${{ matrix.test-case }}

- name: Upload test results to Codecov
if: ${{ !cancelled() && success() && matrix.test-case == 'test-coverage-only' }}
uses: codecov/test-results-action@v1
with:
files: reports/coverage-junit.xml,!./cache
flags: ${{ matrix.python-version }}
token: ${{ secrets.CODECOV_TOKEN }}
# disable due to confusing and unhelpful messages created by codecov
# (see )https://github.com/codecov/feedback/issues/304#issuecomment-2492675117)
# - name: Upload test results to Codecov
# if: ${{ !cancelled() && success() && matrix.test-case == 'test-coverage-only' }}
# uses: codecov/test-results-action@v1
# with:
# files: reports/coverage-junit.xml,!./cache
# flags: ${{ matrix.python-version }}
# token: ${{ secrets.CODECOV_TOKEN }}
- name: Upload coverage report
uses: codecov/codecov-action@v2
if: ${{ success() && matrix.test-case == 'test-coverage-only' }}
Expand Down
Loading