Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test failure #15

Closed
wants to merge 2 commits into from
Closed

test failure #15

wants to merge 2 commits into from

Conversation

andrewseguin
Copy link 

HeadlessChrome 83.0.4103 (Mac OS X 10.15.6) MatSelect with placeholder in ngcontainer with ngIf should set the select value FAILED
	Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'attr.aria-labelledby': ' mat-select-value-1'. Current value: 'mat-form-field-label-1 mat-select-value-1'.
	    at throwErrorIfNoChangesMode (packages/core/src/render3/errors.ts:59:9 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:5802:15)
	    at bindingUpdated (packages/core/src/render3/bindings.ts:62:9 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:13683:21)
	    at ɵɵattribute (packages/core/src/render3/instructions/attribute.ts:33:7 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:13734:13)
	    at MatSelect_HostBindings (src/material/select/select.js:1183:199)
	    at setHostBindingsByExecutingExpandoInstructions (packages/core/src/render3/instructions/shared.ts:109:13 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:7556:29)
	    at refreshView (packages/core/src/render3/instructions/shared.ts:469:5 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:7846:13)
	    at refreshEmbeddedViews (packages/core/src/render3/instructions/shared.ts:1643:9 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:8894:21)
	    at refreshView (packages/core/src/render3/instructions/shared.ts:444:5 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:7824:13)
	    at refreshComponent (packages/core/src/render3/instructions/shared.ts:1693:7 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:8940:17)
	    at refreshChildComponents (packages/core/src/render3/instructions/shared.ts:147:5 <- npm/node_modules/@angular/core/__ivy_ngcc__/bundles/core.umd.js:7593:13)

crisbeto and others added 2 commits August 12, 2020 17:34
@crisbeto
fix(select): use combobox pattern for accessibility
6cc97f6 
Applies some of our recent learnings on how to handle the accessibility of a custom select to `mat-select`. Includes switching the trigger to be a `combobox` and the panel to a `listbox`.

Fixes angular#11083.
@andrewseguin
test failure
d7e66aa
@andrewseguin andrewseguin requested a review from crisbeto as a code owner August 20, 2020 05:09
@andrewseguin andrewseguin mentioned this pull request Aug 20, 2020
Merged
@crisbeto crisbeto force-pushed the select-a11y-fixup branch 2 times, most recently from 195f15e to d9214df Compare August 20, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewseguin @crisbeto