First implementation #1
Conversation
| elevated_username: System | ||
| elevated_password: null | ||
| driver_config: | ||
| box: criteo-windows-2012r2-standard |
There was a problem hiding this comment.
this box is not accessible from the internet.
I suggest not to commit this kitchen.yml file since it will be hard to use over kitchen.ec2
There was a problem hiding this comment.
as discussed i've kept both
There was a problem hiding this comment.
ok, discussed offline, let's keep it
| @@ -0,0 +1,23 @@ | |||
| -----BEGIN RSA PRIVATE KEY----- | |||
There was a problem hiding this comment.
are you sure you want to commit a private key?
| name 'w32time' | ||
| maintainer 'Nicolas BENOIT' | ||
| maintainer_email '[email protected]' | ||
| license 'All rights reserved' |
There was a problem hiding this comment.
license must be apache for all our open source cookbook
| # Command to configure w32time service | ||
| # 0x8 stands for time client | ||
| execute 'set ntp config' do | ||
| command "w32tm /config /update /manualpeerlist:\"#{node['w32time']['ntpserver']},0x8\" /syncfromflags:manual /reliable:yes" |
There was a problem hiding this comment.
OPT: #{node['w32time']['ntpserver']},0x8 is repeated twice, it might worth it to have a variable for that
There was a problem hiding this comment.
I'm wondering, is the w32tm /config required if you configure the registry key.
There was a problem hiding this comment.
the w32tm configuration makes sure all the required registry keys are set properly.
It could be more than the two already checked depending on the previous configuration (for instance from nt5ds some other keys may be altered).
Do you think it would be mandatory to remove it?
| # Command to configure w32time service | ||
| # 0x8 stands for time client | ||
| execute 'set ntp config' do | ||
| command "w32tm /config /update /manualpeerlist:\"#{node['w32time']['ntpserver']},0x8\" /syncfromflags:manual /reliable:yes" |
There was a problem hiding this comment.
I'm wondering, is the w32tm /config required if you configure the registry key.
|
|
||
| # Make sure w32time service is running | ||
| service node['w32time']['service'] do | ||
| service_name node['w32time']['service'] |
There was a problem hiding this comment.
This line is not required because the resource name will be the default value
| @@ -0,0 +1,6 @@ | |||
| #service name definition | |||
| default['w32time']['service'] = 'w32time' | |||
There was a problem hiding this comment.
I think we can hardcode this instead of having an attribute for a value that'll "never" change
| @@ -0,0 +1,6 @@ | |||
| #service name definition | |||
| default['w32time']['service'] = 'w32time' | |||
There was a problem hiding this comment.
I think we can hardcode this instead of having an attribute for a value that'll "never" change
| # This recipe will Configure w32time service to use ntp | ||
|
|
||
| # Make sure w32time service is running | ||
| service node['w32time']['service'] do |
There was a problem hiding this comment.
I think you can hardcode w32time for now
tionebsalocin
force-pushed
the
FirstImplementation
branch
from
8e57482 to
146ab09
Compare
|
lgtm, let's make test pass and merge |
tionebsalocin
force-pushed
the
FirstImplementation
branch
from
146ab09 to
8c74bed
Compare
Contains: