Audit sessions and fix an empty accessorID issue #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrulatout
commented
Jul 1, 2024
•
mbrulatout
commented
- Release criteo5
added 2 commits
July 1, 2024 19:24
The first one avoids code duplication related to error message handling. The second one wraps the accessorID to avoid an empty field causing audit log forwarding issues related to the way we parse audit logs in the first place.
mbrulatout
requested review from
dclaisse,
pierrecdn,
cpaillet,
mougams and
manu-ns
dclaisse
approved these changes
Jul 4, 2024
manu-ns
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.