Problem: error in destroyCoreClient (fix #346) #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leejw51crypto
force-pushed
the
feature/346
branch
from
d18b609 to
6ed3488
Compare
|
|
adding more protection for garbage collection |
leejw51crypto
force-pushed
the
feature/346
branch
from
6ed3488 to
4574098
Compare
|
check validity of |
leejw51crypto
force-pushed
the
feature/346
branch
2 times, most recently
from
d09387c to
551e9fb
Compare
|
default polling time can be small value such as 10 milli-seconds, and wait in unreal engine blueprint |
leejw51crypto
force-pushed
the
feature/346
branch
3 times, most recently
from
f0b663f to
9a4beee
Compare
fix error in polling fix crash add _coreClient check reformat use weakthis fix crash in polling wait for async task timeout reduce default polling time wait at least polling time remove automatic polling changelog update
leejw51crypto
force-pushed
the
feature/346
branch
from
9a4beee to
f25f9c2
Compare
rarcifa
approved these changes
Jan 2, 2024
| AsyncTask(ENamedThreads::AnyHiPriThreadNormalTask, [Out, coreclient, | ||
| address, chain_id, info, | ||
| this]() { | ||
| WeakThis]() { | ||
| if (!WeakThis.IsValid()) { |
There was a problem hiding this comment.
This condition is evoked multiple times. Maybe we can create a helper funtion. Something like
Example
handleIfValid(weakThis, [](auto obj) {
// Code that requires a valid object
obj->someMethod();
});And then just invoke that function.
There was a problem hiding this comment.
ok, i'll check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove AsyncTask in destroyCoreClient