-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rootless): help detection with execv check "is current builder rootless?" #1380
Conversation
…ootless?" Signed-off-by: Pierre Fenoll <[email protected]>
does |
Alright I'll see about extracting this then, then :) |
Signed-off-by: Pierre Fenoll <[email protected]>
Signed-off-by: Pierre Fenoll <[email protected]>
Signed-off-by: Pierre Fenoll <[email protected]>
@Emilgardis here ya go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I recently encountered #1098 and propose an iteration on the fix in #890
This patch adds a last minute check that looks up the current builder endpoint. This may be seen as a costly operation however, as mentioned in #889
Here's the output of
docker builder inspect
on my rootless install: