Replace unmaintained pyqrcode dependency with qrcode #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyqrcode has not seem any activity since 2015. Replace it with qrcode library that is still maintained. The results are roughly the same; it seems that there is a tiny difference in SVG scale, and the terminal version is half the size as qrcode is using more box drawing characters.
|
awesome, thanks a lot! looks very good, though sadly we lack test coverage - I will test it with crossbar (where this stuff is used), but would expect it to just work. |
|
Thanks. I've tested them by calling the two functions directly, and comparing the results visually. Feel free to ping me if you run into any problems. |
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 17, 2022
* Backport crossbario/autobahn-python#1580, so that tests pass without XBR dependencies * Add missing dependency - reminded by crossbario/autobahn-python#1573 git-svn-id: file:///srv/repos/svn-community/svn@1238293 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github
pushed a commit
to archlinux/svntogit-community
that referenced
this pull request
Jun 17, 2022
* Backport crossbario/autobahn-python#1580, so that tests pass without XBR dependencies * Add missing dependency - reminded by crossbario/autobahn-python#1573 git-svn-id: file:///srv/repos/svn-community/svn@1238293 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyqrcode has not seem any activity since 2015. Replace it with qrcode
library that is still maintained. The results are roughly the same;
it seems that there is a tiny difference in SVG scale, and the terminal
version is half the size as qrcode is using more box drawing characters.