Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove #[allow(unsafe_code)] from select! macro #431

Merged
merged 1 commit into from
May 20, 2020
Merged

Remove #[allow(unsafe_code)] from select! macro #431

merged 1 commit into from
May 20, 2020

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Oct 16, 2019 •
edited
Loading

Replaces #430

Closes #405

@taiki-e taiki-e mentioned this pull request Oct 16, 2019
Closed
@ghost
Copy link

ghost commented Oct 22, 2019

Hmmm, why is this failing on Travis CI? Does this require a newer version of the compiler?

@taiki-e
Copy link
Member Author

taiki-e commented Oct 22, 2019

The behavior on which this PR depends is introduced in rust-lang/rust#52467 and has been available since 1.29.

@taiki-e
Copy link
Member Author

taiki-e commented Oct 22, 2019

(Personally, I think it's fine to postpone the fix of #405 until the minimum supported version is 1.29+.)

@extrawurst
Copy link
Contributor

when is that

(Personally, I think it's fine to postpone the fix of #405 until the minimum supported version is 1.29+.)

@taiki-e when is that gonna be ?

@ghost ghost mentioned this pull request May 19, 2020
Open
@ghost
Copy link

ghost commented May 20, 2020

@taiki-e Feel free to merge this PR if you think it's ready!

@taiki-e
Copy link
Member Author

taiki-e commented May 20, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 20, 2020

Build succeeded:

@bors bors bot merged commit 5f3be95 into crossbeam-rs:master May 20, 2020
@taiki-e taiki-e deleted the unsafe-code branch May 20, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to use select macro in #![forbid(unsafe_code)] environments
2 participants
@taiki-e @extrawurst