Apply suggestions from code review

Co-authored-by: Philippe Scorsolini <[email protected]> Signed-off-by: Steven Borrelli <[email protected]>
crossplane-contrib · Oct 8, 2024 · f01d533 · f01d533
1 parent ed7d8f4
commit f01d533
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -193,6 +193,8 @@ apiVersion: meta.gotemplating.fn.crossplane.io/v1alpha1
 kind: Context
 data:
   "apiextensions.crossplane.io/environment":
+      kind: Environment
+      apiVersion: internal.crossplane.io/v1alpha1
       update: environment
       nestedEnvUpdate:
         hello: world

diff --git a/example/context/README.md b/example/context/README.md
@@ -47,17 +47,13 @@ fields:
       hello: world
     update: environment
   newkey:
-    apiVersion: internal.crossplane.io/v1alpha1
     hello: world
-    kind: Environment
   other-context-key:
-    apiVersion: internal.crossplane.io/v1alpha1
     complex:
       a: b
       c:
         d: e
         f: "1"
-    kind: Environment
 kind: Context
 ```
 

diff --git a/example/context/composition.yaml b/example/context/composition.yaml
@@ -34,8 +34,8 @@ spec:
           data:
             # update existing EnvironmentConfig by using the "apiextensions.crossplane.io/environment" key
             "apiextensions.crossplane.io/environment":
-               kind: Environment,
-               apiVersion: internal.crossplane.io/v1alpha1,
+               kind: Environment
+               apiVersion: internal.crossplane.io/v1alpha1
                update: environment
                nestedEnvUpdate:
                  hello: world