added ability to set custom template delims

[AndrewChubatiuk]

Description of your changes

Added ability to set custom template delims to avoid using escaping, while using Helm

[negz]

Suggested change

	// Template start characters
	LeftDelims string `json:"leftDelims,omitempty"`
	// Template end characters
	RightDelims string `json:"rightDelims,omitempty"`
	// Template start characters
	// +optional
	LeftDelims *string `json:"leftDelims,omitempty"`
	// Template end characters
	// +optional
	RightDelims *string `json:"rightDelims,omitempty"`

These are optional, right? Even though this isn't a real CRD we try to follow CRD conventions. So for optional fields we want them to be pointers, and have the +optional comment marker.

[AndrewChubatiuk]

Done as well

[negz]

Could you please add a new directory under example showing how to use these? The example should have everything it needs to be run with crossplane beta render. Thank you!

[AndrewChubatiuk]

Could you please add a new directory under example showing how to use these? The example should have everything it needs to be run with crossplane beta render. Thank you!

Done

[AndrewChubatiuk]

Hey @negz
Sorry for bothering you
Do you expect any additional changes here?

[ezgidemirel]

Hi @AndrewChubatiuk, thanks for your PR! It looks like some of the unit tests are failing. Could you please fix them and sign your commits?

[AndrewChubatiuk]

Hi @AndrewChubatiuk, thanks for your PR! It looks like some of the unit tests are failing. Could you please fix them and sign your commits?

HI @ezgidemirel
fixed all checks

[phisco]

maybe config is a bit generic? all the other fields below (source/inline/filesystem) could easily be below config. WDYT about templateConfig? CC @turkenh

[AndrewChubatiuk]

removed config level and left just delims config

[AndrewChubatiuk]

@ezgidemirel @turkenh @phisco
Are you okay with these changes now?

[phisco]

LGTM! thanks @AndrewChubatiuk!

[ezgidemirel]

Thanks @AndrewChubatiuk!