Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamodb writeConnectionSecretToRef does not write secret data #580

Closed
timpur opened this issue Mar 8, 2021 · 5 comments · Fixed by #839 or #924
Closed

Dynamodb writeConnectionSecretToRef does not write secret data #580

timpur opened this issue Mar 8, 2021 · 5 comments · Fixed by #839 or #924
Labels
bug Something isn't working

Comments

@timpur
Copy link

timpur commented Mar 8, 2021

What happened?

Creaded Dynamobd with

    reason: Available
    status: "True"
    type: Ready

    reason: ReconcileSuccess
    status: "True"
    type: Synced

but no connection string written to the writeConnectionSecretToRef secret. Its created with no data?

Secret (redacted) :

apiVersion: v1
kind: Secret
metadata:
  creationTimestamp: "2021-03-05T03:26:00Z"
  name: dynamodb-my-db
  ownerReferences:
  - apiVersion: dynamodb.aws.crossplane.io/v1alpha1
    controller: true
    kind: Table
type: connection.crossplane.io/v1alpha1

How can we reproduce it?

apiVersion: dynamodb.aws.crossplane.io/v1alpha1
kind: Table
#...#
  forProvider:
    attributeDefinitions:
    - attributeName: attribute1
      attributeType: S
    keySchema:
    - attributeName: attribute1
      keyType: HASH
    provisionedThroughput:
      readCapacityUnits: 1
      writeCapacityUnits: 1
    region: ap-southeast-2
    streamSpecification:
      streamEnabled: true
      streamViewType: NEW_AND_OLD_IMAGES
  providerConfigRef:
    name: default
  writeConnectionSecretToRef:
    name: dynamodb-my-db
    namespace: #...#

What environment did it happen in?

Crossplane version: v0.17.0

@timpur timpur added the bug Something isn't working label Mar 8, 2021
@timpur timpur changed the title Dynamodb writeConnectionSecretToRef not writing secret Dynamodb writeConnectionSecretToRef does not write secret data Mar 8, 2021
@muvaf
Copy link
Member

muvaf commented Mar 8, 2021

Seems like Table does not publish any credentials. What did you expect to see published? For example, it's URL, username and password for RDS DB Instances.

@timpur
Copy link
Author

timpur commented Mar 8, 2021

We'll S3 bucket publishes endpoint (full bucket name) and region. So I was expecting the same ? Since you need the full db name to access it ?

@muvaf
Copy link
Member

muvaf commented Mar 9, 2021

@timpur sounds good. Would you like to contribute this? You'd need to add a ConnectionDetails (map[string][]byte) here to obs object that contains that information retrieved from resp object.

@cookiefission
Copy link

A slight side note to this issue for other folks who might land here from search.

If you try to use a Table object in a Composition and specify connectionDetails to generate the connection details manually, the secret is still never written (in some cases) due to the underlying tables.dynamodb.aws.crossplane.io resource never becoming synced (#637, despite the title the issue affects more than just billingMode).

@haarchri
Copy link
Member

can you have a look in #839 - we can provide with the MR the following key/values:

  LatestStreamArn
  LatestStreamLabel
  TableArn
  TableName

@negz negz closed this as completed in #839 Nov 10, 2021
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this issue Mar 12, 2024
…ib#580)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants