-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement glue objects #686
Conversation
@haarchri Please rebase on master and we can run this through testing. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. All resources created and deleted successfully. Thanks, @haarchri!
Please resolve the remaining conflicts and we can merge.
cf39c5c
to
b5c396f
Compare
@AaronME ready - can you have a look ? ref & selector implemented, rebased and adjusted the examples - also added iam stuff needed for gets glue running ;) thanks for your time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haarchri Works great!
Please update the ProviderConfigRefs to example,
then I can approve and merge.
Also, I've noticed you are not implementing isUpToDate
, which means your resources can only be created and destroyed. Is this intentional?
Thank you for all your contributions!
@haarchri do not worry about rebasing when you make the next changes. |
@AaronME i will have a look in a followup for thanks for your time |
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Christopher Haar <[email protected]>
…roller-gen.kubebuilder.io/version v0.6.2 Signed-off-by: haarchri <[email protected]>
@AaronME all checks passed ;) |
IRSA auth and Use our product feedback
Signed-off-by: Christopher Haar [email protected]
Description of your changes
added following glue services:
#Fixes #522
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
created & deleted all objects from example/glue & example/iam
overview: