Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement glue objects #686

Merged
merged 3 commits into from
Oct 5, 2021
Merged

Implement glue objects #686

merged 3 commits into from
Oct 5, 2021

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented May 31, 2021

Signed-off-by: Christopher Haar [email protected]

Description of your changes

added following glue services:

  • classifier
  • connection
  • crawler
  • database
  • job
  • securityconfiguration

#Fixes #522
I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

created & deleted all objects from example/glue & example/iam
overview:

kubectl get managed | grep "glue"
database.glue.aws.crossplane.io/glue-database   True    True     glue-database
classifier.glue.aws.crossplane.io/glue-classifier-csv    True    True     glue-classifier-csv
classifier.glue.aws.crossplane.io/glue-classifier-grok   True    True     glue-classifier-grok
classifier.glue.aws.crossplane.io/glue-classifier-json   True    True     glue-classifier-json
classifier.glue.aws.crossplane.io/glue-classifier-xml    True    True     glue-classifier-xml
securityconfiguration.glue.aws.crossplane.io/glue-securityconfiguration   True    True     glue-securityconfiguration
job.glue.aws.crossplane.io/glue-job   True    True     glue-job
crawler.glue.aws.crossplane.io/glue-crawler   True    True     glue-crawler
connection.glue.aws.crossplane.io/glue-connection   True    True     glue-connection
iamrole.identity.aws.crossplane.io/glue-role      True    True     8h
iamrolepolicyattachment.identity.aws.crossplane.io/glue-rolepolicyattachment                 True    True     glue-role      arn:aws:iam::255932642927:policy/glue-policy                 8h
iampolicy.identity.aws.crossplane.io/glue-policy   arn:aws:iam::255932642927:policy/glue-policy   True    True     8h

@haarchri haarchri changed the title added glue objects Implement glue objects Jun 21, 2021
@AaronME
Copy link

AaronME commented Sep 24, 2021

@haarchri Please rebase on master and we can run this through testing.

Thank you!

@AaronME AaronME self-assigned this Sep 24, 2021
@AaronME AaronME self-requested a review September 30, 2021 03:14
Copy link

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. All resources created and deleted successfully. Thanks, @haarchri!

Please resolve the remaining conflicts and we can merge.

@haarchri haarchri force-pushed the glue branch 2 times, most recently from cf39c5c to b5c396f Compare September 30, 2021 19:24
@haarchri
Copy link
Member Author

@AaronME ready - can you have a look ? ref & selector implemented, rebased and adjusted the examples - also added iam stuff needed for gets glue running ;)

thanks for your time

@AaronME AaronME self-requested a review September 30, 2021 21:18
Copy link

@AaronME AaronME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haarchri Works great!

Please update the ProviderConfigRefs to example, then I can approve and merge.

Also, I've noticed you are not implementing isUpToDate, which means your resources can only be created and destroyed. Is this intentional?

Thank you for all your contributions!

examples/glue/classifier.yaml Outdated Show resolved Hide resolved
examples/glue/classifier.yaml Outdated Show resolved Hide resolved
examples/glue/classifier.yaml Outdated Show resolved Hide resolved
examples/glue/classifier.yaml Outdated Show resolved Hide resolved
examples/glue/connection.yaml Outdated Show resolved Hide resolved
examples/glue/crawler.yaml Outdated Show resolved Hide resolved
examples/glue/database.yaml Outdated Show resolved Hide resolved
examples/glue/job.yaml Outdated Show resolved Hide resolved
examples/glue/securityconfiguration.yaml Outdated Show resolved Hide resolved
@AaronME
Copy link

AaronME commented Oct 1, 2021

@haarchri do not worry about rebasing when you make the next changes.

@haarchri
Copy link
Member Author

haarchri commented Oct 1, 2021

@AaronME i will have a look in a followup for isUpToDate - not all glue services can be updated ..
for now master rebased & example adjusted

thanks for your time

@AaronME
Copy link

AaronME commented Oct 5, 2021

@haarchri I attempted to resolve a conflict with a previous merge and it appears to be causing some test failures.

@muvaf - let's sync on this to figure out what this PR needs. Passed testing before my commit.

@haarchri
Copy link
Member Author

haarchri commented Oct 5, 2021

@AaronME can you have a look now ? i changed the ratelimiter & run regeneration
commit: c1e250b

on local machine make reviewable and make check-diff is working
did you want to have a look ?
thanks

@haarchri
Copy link
Member Author

haarchri commented Oct 5, 2021

@AaronME all checks passed ;)

@AaronME AaronME merged commit 4339c3a into crossplane-contrib:master Oct 5, 2021
@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
tektondeploy pushed a commit to gtn3010/provider-aws that referenced this pull request Mar 12, 2024
IRSA auth and Use our product feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Amazon Glue service
2 participants