Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sfn 404 for deletion #730

Merged
merged 1 commit into from
Jun 18, 2021
Merged

fix sfn 404 for deletion #730

merged 1 commit into from
Jun 18, 2021

Conversation

haarchri
Copy link
Member

Signed-off-by: Christopher Haar [email protected]

fixed ressources exeptions errors in generator-config.yaml for sfn

Description of your changes

Fixes #725

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

statemachine:

➜  sfn git:(master) ✗ kubectl apply -f statemachine.yaml 
statemachine.sfn.aws.crossplane.io/sample-statemachine created
➜  sfn git:(master) ✗ kubectl delete -f statemachine.yaml
statemachine.sfn.aws.crossplane.io "sample-statemachine" deleted

activity:

➜  sfn git:(master) ✗ kubectl apply -f activity.yaml 
activity.sfn.aws.crossplane.io/sample-activity created
➜  sfn git:(master) ✗ kubectl delete -f activity.yaml 
activity.sfn.aws.crossplane.io "sample-activity" deleted

output from deletion:

statemachine:

2021-06-17T10:05:26.162+0200	DEBUG	controller-runtime.manager.events	Normal	{"object": {"kind":"Key","name":"kms-key-test","uid":"5033fe49-14b3-4c50-8590-b2924cac3476","apiVersion":"kms.aws.crossplane.io/v1alpha1","resourceVersion":"124666"}, "reason": "DeletedExternalResource", "message": "Successfully requested deletion of external resource"}
2021-06-17T10:05:48.934+0200	DEBUG	provider-aws	Reconciling	{"controller": "managed/statemachine.sfn.aws.crossplane.io", "request": "/sample-statemachine"}
2021-06-17T10:05:49.050+0200	DEBUG	provider-aws	Successfully deleted managed resource	{"controller": "managed/statemachine.sfn.aws.crossplane.io", "request": "/sample-statemachine", "uid": "fb0b9575-56f4-43f6-bce7-d92bbd403071", "version": "157968", "external-name": "arn:aws:states:eu-central-1:255932642927:stateMachine:sample-statemachine", "deletion-timestamp": "2021-06-17 10:04:55 +0200 CEST"}
2021-06-17T10:05:49.050+0200	DEBUG	provider-aws	Reconciling	{"controller": "managed/statemachine.sfn.aws.crossplane.io", "request": "/sample-statemachine"}
2021-06-17T10:05:49.050+0200	DEBUG	provider-aws	Cannot get managed resource	{"controller": "managed/statemachine.sfn.aws.crossplane.io", "request": "/sample-statemachine", "error": "StateMachine.sfn.aws.crossplane.io \"sample-statemachine\" not found"}

activity:

2021-06-17T10:20:53.954+0200	DEBUG	provider-aws	Reconciling	{"controller": "managed/activity.sfn.aws.crossplane.io", "request": "/sample-activity"}
2021-06-17T10:20:54.024+0200	DEBUG	provider-aws	Successfully deleted managed resource	{"controller": "managed/activity.sfn.aws.crossplane.io", "request": "/sample-activity", "uid": "9de3e722-644b-45cb-983a-5580e01d0faf", "version": "161612", "external-name": "arn:aws:states:eu-central-1:255932642927:activity:sample-activity", "deletion-timestamp": "2021-06-17 10:20:53 +0200 CEST"}
2021-06-17T10:20:54.024+0200	DEBUG	provider-aws	Reconciling	{"controller": "managed/activity.sfn.aws.crossplane.io", "request": "/sample-activity"}
2021-06-17T10:20:54.024+0200	DEBUG	provider-aws	Cannot get managed resource	{"controller": "managed/activity.sfn.aws.crossplane.io", "request": "/sample-activity", "error": "Activity.sfn.aws.crossplane.io \"sample-activity\" not found"}
2021-06-17T10:20:54.681+0200	DEBUG	provider-aws	Reconciling	{"controller": "managed/activity.sfn.aws.crossplane.io", "request": "/sample-activity"}
2021-06-17T10:20:54.682+0200	DEBUG	provider-aws	Cannot get managed resource	{"controller": "managed/activity.sfn.aws.crossplane.io", "request": "/sample-activity", "error": "Activity.sfn.aws.crossplane.io \"sample-activity\" not found"}

Signed-off-by: Christopher Haar <[email protected]>
Copy link
Member

@muvaf muvaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @haarchri !

@muvaf muvaf merged commit 3243f6c into crossplane-contrib:master Jun 18, 2021
@haarchri haarchri mentioned this pull request Oct 21, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't delete SFN activities and state machines
2 participants