-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version: bump ec2/vpccidrblock package to manualv1alpha1 #751
version: bump ec2/vpccidrblock package to manualv1alpha1 #751
Conversation
I see what you are saying. And I agree that it would be nice to have a distinction between the generated and non-generated types. Could using |
so what is your prefered way ? at the moment we need to modify in ec2 zz_ files if we want integrate more services with code-generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haarchri we don't need to actually change the API version, we can just change the package name so that the generated code lives in a different package. Users of this API should have the same experience as they do currently 👍🏻
@hasheddan can you provide a example ? At the moment the code-generator will add in ec2 v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haarchri left some guiding comments below, let me know if you want to sync up about them if they aren't illustrating my suggestions well 👍🏻
2eeeed9
to
1ff3962
Compare
@hasheddan i changed the packag to manualv1alpha1 and the generated crds using v1alpha1 - think this was this what you mentioned ;) tested via apply and delete for delete i added a fix that the ressource is removed when vpccidrblock is in status VpcCidrBlockStateCodeDisassociated |
1ff3962
to
bda4493
Compare
Signed-off-by: Christopher Haar <[email protected]>
bda4493
to
bd2f88a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @haarchri !
Signed-off-by: Christopher Haar [email protected]
bump package version for ec2/vpccidrblock to manualv1alpha1 to use v1alpha1 for code-generator stuff
in #689 we see the problem between custom and code-generator stuff in one - for example: of zz_types.go
think it is better not mix-up the both approaches
what did you guys think ?
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested