Support for Object Store #50
Conversation
|
|
||
| // A CivoObjectStoreSpec defines the desired state of a CivoObjectStore. | ||
| type CivoObjectStoreSpec struct { | ||
| // User Given name to the Object Store |
There was a problem hiding this comment.
| // User Given name to the Object Store | |
| // Name for object store(aka bucket). Name needs to be unique across the entire region |
| Name string `json:"name"` | ||
|
|
||
| // Size of object store, should be specified in GB | ||
| // +kubebuilder:default:=500 |
There was a problem hiding this comment.
IIRC, it also needs to be a multiple of 500. Maybe we should mention that
| // +kubebuilder:default:=500 | ||
| Size int64 `json:"size,omitempty"` | ||
|
|
||
| ConnectionDetails CivoObjectStoreConnectionDetails `json:"connectionDetails"` |
There was a problem hiding this comment.
Missing description on field. These fields is the only help menu we provide to the user. When they do a kubectl explain they can view the description we give. We should mention that this is going to be the place where we store access key and secret access key.
| // A CivoObjectStore is an example API type. | ||
| // +kubebuilder:printcolumn:name="READY",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status" | ||
| // +kubebuilder:printcolumn:name="MESSAGE",type="string",JSONPath=".status.message" | ||
| // +kubebuilder:printcolumn:name="APPLICATIONS",type="string",JSONPath=".spec.applications" |
There was a problem hiding this comment.
| // +kubebuilder:printcolumn:name="APPLICATIONS",type="string",JSONPath=".spec.applications" |
| // +kubebuilder:printcolumn:name="READY",type="string",JSONPath=".status.conditions[?(@.type=='Ready')].status" | ||
| // +kubebuilder:printcolumn:name="MESSAGE",type="string",JSONPath=".status.message" | ||
| // +kubebuilder:printcolumn:name="APPLICATIONS",type="string",JSONPath=".spec.applications" | ||
| // Please replace `PROVIDER-NAME` with your actual provider name, like `aws`, `azure`, `gcp`, `alibaba` |
There was a problem hiding this comment.
| // Please replace `PROVIDER-NAME` with your actual provider name, like `aws`, `azure`, `gcp`, `alibaba` |
| Name string `json:"Name"` | ||
|
|
||
| // Size of object store | ||
| Size int64 `json:"Size"` |
There was a problem hiding this comment.
Size can be interpreted as either used or total available capacity. We should be explicit about what size we're talking about here and should also have both the fields here.
| type CivoObjectStoreObservation struct { | ||
|
|
||
| // User Given name to the Object Store | ||
| Name string `json:"Name"` |
There was a problem hiding this comment.
Do we really need name again?
| Size int64 `json:"Size"` | ||
|
|
||
| // Status of the Object Store (e.g., Creating, Available, Deleting) | ||
| Status string `json:"status,omitempty"` |
There was a problem hiding this comment.
Curious if Crossplane encourages Conditions to report status. If nothing is mentioned, let's just use Conditions and not have a Status field.
https://heidloff.net/article/storing-state-status-kubernetes-resources-conditions-operators-go/
| @@ -0,0 +1,21 @@ | |||
| /* | |||
| Copyright 2020 The Crossplane Authors. | |||
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested