-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing broken links about GCP documentation #452
fixing broken links about GCP documentation #452
Conversation
9ab7906
to
1ede501
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
I think you need to run make generate
locally as well and commit the changes, so they are passed to the generated CRD manifests (it will change the field description)
@Feggah when I do ➜ provider-gcp git:(docs.crd.dev/fixing-broken-links) make generate
make: *** No rule to make target `generate'. Stop. |
Got it. Try to run |
thanks @Feggah I had to do:
But it seems golangci-lint is not compatible with Go 1.19 which is the version I have in my M1 Macbook: WARN [runner] Can't run linter unused: buildir: failed to load package goarch: could not load export data: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool
ERRO Running error: buildir: failed to load package goarch: could not load export data: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool
15:10:42 [FAIL]
make[2]: *** [go.lint] Error 1
make[1]: *** [build.all] Error 2
make: *** [build] Error 2
|
90f627d
to
e5a3d57
Compare
cool @Feggah installed go 1.17 with |
Can you change your last commit and force push again (maybe change the commit message?) The github workflow is stuck and I can't cancel/re-run it. |
Signed-off-by: Andre Almar <[email protected]>
Signed-off-by: Andre Almar <[email protected]>
Signed-off-by: Andre Almar <[email protected]>
9665075
to
08d3240
Compare
@Feggah did it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort, @andrealmar! 🙂
Description of your changes
Fixes #
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested