Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing broken links about GCP documentation #452

Merged

Conversation

andrealmar
Copy link
Contributor

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

@andrealmar andrealmar force-pushed the docs.crd.dev/fixing-broken-links branch from 9ab7906 to 1ede501 Compare August 17, 2022 02:10
Copy link
Collaborator

@Feggah Feggah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

I think you need to run make generate locally as well and commit the changes, so they are passed to the generated CRD manifests (it will change the field description)

@andrealmar
Copy link
Contributor Author

@Feggah when I do make generate on the root folder of the project it is giving me:

➜  provider-gcp git:(docs.crd.dev/fixing-broken-links) make generate
make: *** No rule to make target `generate'.  Stop.

@Feggah
Copy link
Collaborator

Feggah commented Aug 17, 2022

Got it. Try to run make first and then make generate, @andrealmar. It's kinda tricky but you need to run make before any Makefile target

@andrealmar
Copy link
Contributor Author

thanks @Feggah I had to do:

go mod tidy to fetch the dependencies and then after I didmake

But it seems golangci-lint is not compatible with Go 1.19 which is the version I have in my M1 Macbook:

WARN [runner] Can't run linter unused: buildir: failed to load package goarch: could not load export data: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool 
ERRO Running error: buildir: failed to load package goarch: could not load export data: cannot import "internal/goarch" (unknown iexport format version 2), export data is newer version - update tool 
15:10:42 [FAIL]
make[2]: *** [go.lint] Error 1
make[1]: *** [build.all] Error 2
make: *** [build] Error 2

@Feggah
Copy link
Collaborator

Feggah commented Aug 17, 2022

I would suggest you to use gvm to manage your local Go version. This repository is using go1.17, I think it won't work with go1.19

@andrealmar andrealmar force-pushed the docs.crd.dev/fixing-broken-links branch from 90f627d to e5a3d57 Compare August 17, 2022 21:00
@andrealmar
Copy link
Contributor Author

cool @Feggah installed go 1.17 with gvm, ran make generate and pushed the changes again.

@Feggah
Copy link
Collaborator

Feggah commented Aug 19, 2022

Can you change your last commit and force push again (maybe change the commit message?) The github workflow is stuck and I can't cancel/re-run it.

@andrealmar andrealmar force-pushed the docs.crd.dev/fixing-broken-links branch from 9665075 to 08d3240 Compare August 19, 2022 17:17
@andrealmar
Copy link
Contributor Author

@Feggah did it

Copy link
Collaborator

@Feggah Feggah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort, @andrealmar! 🙂

@Feggah Feggah merged commit aa16e20 into crossplane-contrib:master Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants