Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous deployment of helm releases #63

Open
turkenh opened this issue Nov 4, 2020 · 4 comments
Open

Asynchronous deployment of helm releases #63

turkenh opened this issue Nov 4, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@turkenh
Copy link
Collaborator

turkenh commented Nov 4, 2020

What problem are you facing?

Currently, install and upgrade calls using helm go client is blocking which means, reconcile loop is being blocked until deployment is done. Since we don't set wait (related), this is fine if chart does not contain hooks. However, with hooks we encounter problems like this.

How could Crossplane help solve your problem?

We need to make this action asynchronous somehow.

@turkenh turkenh added the enhancement New feature or request label Nov 4, 2020
@turkenh turkenh changed the title Asynchronous deployment of helm charts Asynchronous deployment of helm releases Nov 4, 2020
@turkenh
Copy link
Collaborator Author

turkenh commented Nov 5, 2020

Related: helm/helm#5891

@turkenh turkenh mentioned this issue Nov 5, 2020
2 tasks
@turkenh turkenh self-assigned this Nov 9, 2020
@jbw976
Copy link
Member

jbw976 commented Mar 29, 2022

Are you still working on this @turkenh, or would it be available for someone else to take on?

@turkenh turkenh removed their assignment Mar 29, 2022
@turkenh
Copy link
Collaborator Author

turkenh commented Mar 29, 2022

@jbw976 not really. Just unassigned from myself and available for anyone interested.

@turkenh
Copy link
Collaborator Author

turkenh commented Mar 29, 2022

For posterity, I believe this could be implemented by following a similar approach used in Terrajet: https://github.com/crossplane/terrajet/blob/6142eefbcf5b4e6490a4a39f8ceffa8810911d5f/pkg/terraform/workspace.go#L106

We might even consider to have a cli execution library (sync/async) as a reusable piece of code, e.g. in crossplane-runtime. Not sure if this worths the amount of work required though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants