Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm wait option #4

Closed
turkenh opened this issue Jul 23, 2020 · 2 comments · Fixed by #64
Closed

Helm wait option #4

turkenh opened this issue Jul 23, 2020 · 2 comments · Fixed by #64
Assignees
@turkenh
Labels
enhancement New feature or request
Milestone
Platform Sprint 12

Comments

@turkenh
Copy link
Collaborator

turkenh commented Jul 23, 2020

No description provided.

@turkenh turkenh added the enhancement New feature or request label Jul 23, 2020
@srueg
Copy link
Contributor

srueg commented Oct 28, 2020

Would this result in only setting the Ready condition on a Release, once all resources the chart creates are ready?
If yes it would be a great addition 👍
Currently the installation of a chart can silently fail (e.g. stuck in pending) and the Release still goes into Ready state.

@turkenh turkenh mentioned this issue Nov 4, 2020
Open
@turkenh
Copy link
Collaborator Author

turkenh commented Nov 4, 2020

Yes, similar to helm upgrade --install --wait

It would be an easy addition to make this available as blocking but this is not a good controller pattern. Since, this is already case if chart contains hooks, may be we can fix this issue simply introducing a blocking wait and track making deployments asynchronous as a separate issue.

turkenh added a commit to turkenh/provider-helm that referenced this issue Nov 5, 2020
@turkenh
Add wait option
3f3c86b 
Closes crossplane-contrib#4

Signed-off-by: Hasan Turken <[email protected]>
turkenh added a commit to turkenh/provider-helm that referenced this issue Nov 5, 2020
@turkenh
Add wait option
44bb386 
Closes crossplane-contrib#4

Signed-off-by: Hasan Turken <[email protected]>
@turkenh turkenh changed the title Helm wait (not blocking but checking periodically) Helm wait option Nov 5, 2020
@turkenh turkenh mentioned this issue Nov 5, 2020
Merged
2 tasks
@turkenh turkenh self-assigned this Nov 5, 2020
@turkenh turkenh added this to the Platform Sprint 11 milestone Nov 5, 2020
turkenh added a commit to turkenh/provider-helm that referenced this issue Nov 13, 2020
@turkenh
Add wait option
45a432f 
Closes crossplane-contrib#4

Signed-off-by: Hasan Turken <[email protected]>
negz pushed a commit to negz/provider-helm that referenced this issue Feb 15, 2024
@ulucinar
Merge pull request crossplane-contrib#4 from upbound/pr_Wed_Oct_5_23-…
55e363a 
…05-42_+03_2022

Update Go module & replace commons strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turkenh turkenh

Labels
enhancement New feature or request
Projects
None yet
Milestone
Platform Sprint 12
Development

Successfully merging a pull request may close this issue.

Add wait option turkenh/provider-helm
3 participants
@lukeweber @srueg @turkenh