Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #129

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

barunavo
Copy link
Contributor

@barunavo barunavo commented May 26, 2022

missing "-" line 6

Description of your changes

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Copy link
Contributor

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just hit it on my side, thanks for the catch

@ytsarev
Copy link
Contributor

ytsarev commented Mar 1, 2023

@barunavo could you please add commit signature with git commit -s to comply with DCO?

missing "-" line 6

Signed-off-by: Barunavo Pal <[email protected]>
@barunavo barunavo requested a review from ytsarev March 2, 2023 17:55
Copy link
Collaborator

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @barunavo!

@turkenh turkenh merged commit 29915ca into crossplane-contrib:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants