Bump Terraform provider version to v4.56.0 #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
/test-examples="examples/cloudplatform/serviceaccount.yaml" |
|
/test-examples="examples/containerazure/cluster.yaml" |
|
/test-examples="examples/sql/instance.yaml" |
|
Two MR definitions are reported to have breaking changes: No resources have been reported by the schemadiff tool. |
|
/test-examples="examples/containerazure/cluster.yaml" |
|
/test-examples="examples/sql/instance.yaml" |
sergenyalcin
approved these changes
Mar 10, 2023
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
ulucinar
force-pushed
the
bump-tf-4.56.0
branch
from
3094b94 to
af1890c
Compare
ulucinar
commented
Mar 10, 2023
| @@ -31,6 +31,9 @@ const ( | |||
| // ResourceConfigurators. | |||
| func Configure(p *config.Provider) { //nolint:gocyclo | |||
| p.AddResourceConfigurator("google_sql_database_instance", func(r *config.Resource) { | |||
| // we need to workaround the newly added (with v4.56.0) | |||
| // of `Optional=True` in the native provider | |||
| config.MoveToStatus(r.TerraformResource, "instance_type") | |||
There was a problem hiding this comment.
In v4.56.0 of the Terraform Google provider, Optional: true has been added to the native schema of the instance_type attribute, which moves the generated field to spec. We need to move it back to status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Depends on: crossplane/upjet#172
This PR bumps the underlying Terraform provider version to
v4.56.0.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested resources reported by
crddiff:Cluster.containerazure: https://github.com/upbound/provider-gcp/actions/runs/4378403601sql.DatabaseInstance: https://github.com/upbound/provider-gcp/actions/runs/4378404381