Skip to content

Commit

Permalink
Merge pull request #549 from lsviben/gmp-to-beta
Browse files Browse the repository at this point in the history
GMP to beta
  • Loading branch information
turkenh authored Sep 20, 2023
2 parents ec05d09 + 55a8c10 commit 9597f2a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
5 changes: 2 additions & 3 deletions apis/common/v1/resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,8 @@ type ResourceSpec struct {
// +kubebuilder:default={"name": "default"}
ProviderConfigReference *Reference `json:"providerConfigRef,omitempty"`

// THIS IS AN ALPHA FIELD. Do not use it in production. It is not honored
// unless the relevant Crossplane feature flag is enabled, and may be
// changed or removed without notice.
// THIS IS A BETA FIELD. It is on by default but can be opted out
// through a Crossplane feature flag.
// ManagementPolicies specify the array of actions Crossplane is allowed to
// take on the managed and external resources.
// This field is planned to replace the DeletionPolicy field in a future
Expand Down
4 changes: 2 additions & 2 deletions pkg/feature/features.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ limitations under the License.

package feature

// EnableAlphaManagementPolicies enables alpha support for
// EnableBetaManagementPolicies enables beta support for
// Management Policies. See the below design for more details.
// https://github.com/crossplane/crossplane/pull/3531
const EnableAlphaManagementPolicies Flag = "EnableAlphaManagementPolicies"
const EnableBetaManagementPolicies Flag = "EnableBetaManagementPolicies"
4 changes: 2 additions & 2 deletions pkg/reconciler/managed/reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ func WithRecorder(er event.Recorder) ReconcilerOption {
// WithManagementPolicies enables support for management policies.
func WithManagementPolicies() ReconcilerOption {
return func(r *Reconciler) {
r.features.Enable(feature.EnableAlphaManagementPolicies)
r.features.Enable(feature.EnableBetaManagementPolicies)
}
}

Expand Down Expand Up @@ -752,7 +752,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (resu
"external-name", meta.GetExternalName(managed),
)

managementPoliciesEnabled := r.features.Enabled(feature.EnableAlphaManagementPolicies)
managementPoliciesEnabled := r.features.Enabled(feature.EnableBetaManagementPolicies)
if managementPoliciesEnabled {
log.WithValues("managementPolicies", managed.GetManagementPolicies())
}
Expand Down

0 comments on commit 9597f2a

Please sign in to comment.