Treat all maps & slices of zero-length equal whether they are nil or not in managed.APISimpleReferenceResolver #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not in managed.APISimpleReferenceResolver Signed-off-by: Alper Rifat Ulucinar <[email protected]>
turkenh
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #617
This PR passes the
cmpopts.EquateEmpty()option when themanaged.APISimpleReferenceResolveris checking whether any reference fields (Reffields if a label selector is specified and the reference target fields) have been set by the downstreamResolveReferencescall, so that all maps & slices of zero-length will be considered as equal whether they are nil or empty.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Tested with a custom build of
upbound/provider-aws.