logging: add SetFilteredKlogLogger to show client-go throttling logs #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
It's hard to understand which component is causing slowness. This PR enables client throttling logging, both for server-side and client-side, i.e. these pass:
For example:
This is just in Crossplane. It probably needs a log setup helper in controller-runtime and then vendored into providers.
Of course, this information could also be understood from metrics, but metrics are complicated, hard to discover and need tons of knowledge to understand right.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested in crossplane/crossplane#5419.