Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make query params required and raise corresponding error #27

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

sabarish98
Copy link
Contributor

Changes:

  • Added code to raise error for all the four required parameters - name format sourcePatterns exportPattern

Please let me know if we need tests for these. I wasn't able to find tests for error flow paths, so didn't add them

@andrii-bodnar
Copy link
Member

@sabarish98 some checks have failed, please take a look

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #27 (6bffd8b) into main (24ab6c5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   97.79%   97.79%   +0.01%     
==========================================
  Files          57       57              
  Lines        2484     2486       +2     
==========================================
+ Hits         2429     2431       +2     
  Misses         55       55              
Impacted Files Coverage Δ
lib/crowdin-api/api_resources/bundles.rb 100.00% <100.00%> (ø)
spec/api_resources/bundles_spec.rb 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sabarish98
Copy link
Contributor Author

@andrii-bodnar : Pushed the fix for the case which was failing. The checks should be passing now I hope

@sabarish98 sabarish98 changed the title Req params bundle api Make query params required and raise corresponding error Oct 26, 2022
@andrii-bodnar
Copy link
Member

@sabarish98 thanks a lot for your contribution!

@andrii-bodnar andrii-bodnar linked an issue Oct 26, 2022 that may be closed by this pull request
@andrii-bodnar andrii-bodnar merged commit 5b2d4b2 into crowdin:main Oct 26, 2022
@sabarish98 sabarish98 deleted the req_params_bundle_api branch October 26, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Bundle API - mark some parameters as required
2 participants